Skip to content

pin crds#721

Merged
braingram merged 1 commit into
spacetelescope:mainfrom
braingram:pin_crds
Apr 28, 2026
Merged

pin crds#721
braingram merged 1 commit into
spacetelescope:mainfrom
braingram:pin_crds

Conversation

@braingram
Copy link
Copy Markdown
Collaborator

@braingram braingram commented Apr 28, 2026

The recent release of crds is incompatible with jwst crds run in non-serverless mode (which we use in the CI). This adds an upper pin that we can remove when a compatible release is available.

See: spacetelescope/jwst#10496

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.37%. Comparing base (758be1c) to head (72038d2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          99       99           
  Lines        4582     4582           
=======================================
  Hits         4141     4141           
  Misses        441      441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram marked this pull request as ready for review April 28, 2026 21:04
@braingram braingram requested a review from a team as a code owner April 28, 2026 21:04
Copy link
Copy Markdown
Contributor

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you asked Jonathan whether this was needed for JWST. I'm all for this, it's easy to change back.

@braingram braingram merged commit bdca8db into spacetelescope:main Apr 28, 2026
24 of 26 checks passed
@braingram braingram mentioned this pull request May 6, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed Trivial change that doesn't need an entry in the change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants