Skip to content

remove unnecessary generic_io usage#729

Merged
braingram merged 1 commit into
spacetelescope:mainfrom
braingram:rm_generic_io
May 11, 2026
Merged

remove unnecessary generic_io usage#729
braingram merged 1 commit into
spacetelescope:mainfrom
braingram:rm_generic_io

Conversation

@braingram
Copy link
Copy Markdown
Collaborator

@braingram braingram commented May 5, 2026

Remove an unnecessary usage of asdf.generic_io (there are developing plans to remove this submodule as it's largely unnecessary as seen in this PR).

Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/25395302167
all pass

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.75%. Comparing base (9454993) to head (f75d362).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   90.76%   90.75%   -0.01%     
==========================================
  Files          99       99              
  Lines        4578     4577       -1     
==========================================
- Hits         4155     4154       -1     
  Misses        423      423              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram marked this pull request as ready for review May 5, 2026 21:56
@braingram braingram requested a review from a team as a code owner May 5, 2026 21:56
Copy link
Copy Markdown
Contributor

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram enabled auto-merge May 11, 2026 20:05
@braingram braingram merged commit 37474e8 into spacetelescope:main May 11, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-entry-needed Trivial change that doesn't need an entry in the change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants