Skip to content

Add SUBPRISM_IP/S subarray names#730

Merged
tapastro merged 3 commits into
spacetelescope:mainfrom
tapastro:subprism
May 6, 2026
Merged

Add SUBPRISM_IP/S subarray names#730
tapastro merged 3 commits into
spacetelescope:mainfrom
tapastro:subprism

Conversation

@tapastro
Copy link
Copy Markdown
Collaborator

@tapastro tapastro commented May 6, 2026

Partially resolves JP-4150

This PR addresses a missed mapping from the SLITLESSPRISM_IP/S subarray names to intermediate SUBPRISM_IP/S names - to support processing of the data, we will include these subarray names. We expect DMS builds 13.0+ will have SDP translate these back to SLITLESSPRISM_IP/S, but that has not yet been completed.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@tapastro tapastro requested a review from a team as a code owner May 6, 2026 15:16
@tapastro
Copy link
Copy Markdown
Collaborator Author

tapastro commented May 6, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.35%. Comparing base (8180c4c) to head (1328652).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          99       99           
  Lines        4585     4585           
=======================================
  Hits         4143     4143           
  Misses        442      442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending clean regression tests

@tapastro tapastro merged commit f315cc2 into spacetelescope:main May 6, 2026
22 checks passed
zacharyburnett pushed a commit that referenced this pull request May 6, 2026
zacharyburnett pushed a commit that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants