Fix handling of logical int8 columns#738
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
+ Coverage 90.74% 90.76% +0.01%
==========================================
Files 99 99
Lines 4570 4578 +8
==========================================
+ Hits 4147 4155 +8
Misses 423 423 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emolter
reviewed
May 11, 2026
Contributor
emolter
left a comment
emolter
left a comment
There was a problem hiding this comment.
looks good overall but I had a question
emolter
approved these changes
May 11, 2026
Contributor
emolter
left a comment
emolter
left a comment
There was a problem hiding this comment.
This looks good to me until we can remove fits_rec entirely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #735
Logical/int8 columns are causing warnings for astropy dev and do not work as expected (see above issue).
Update handling of structured arrays/fits_rec with logical/int8 columns copying data where needed to handle the mismatch between numpy bool storage and astropy/fits logical bool mapping.
Regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/25576691180/job/75368198893
github is having issues so CI is unreliable. Will trying to restart some tests.
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change