Skip to content

JP-4313: Add NRC superstripe subarrays#739

Merged
melanieclarke merged 5 commits into
spacetelescope:mainfrom
melanieclarke:jp-4313
Jun 11, 2026
Merged

JP-4313: Add NRC superstripe subarrays#739
melanieclarke merged 5 commits into
spacetelescope:mainfrom
melanieclarke:jp-4313

Conversation

@melanieclarke

@melanieclarke melanieclarke commented May 11, 2026

Copy link
Copy Markdown
Contributor

Toward JP-4313

Add new subarray names for upcoming NIRCam superstripe modes

Also add meta.exposure.read_times to the core schema to allow specification of explicit read times for unevenly sampled readouts. This is needed to support jump detection and ramp fitting for in-frame reads of repeated substripes.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (215ff88) to head (904f3c1).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          99       99           
  Lines        4619     4619           
=======================================
  Hits         4188     4188           
  Misses        431      431           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/stdatamodels/jwst/datamodels/schemas/core.schema.yaml
@melanieclarke melanieclarke force-pushed the jp-4313 branch 2 times, most recently from b5941a1 to 06bc081 Compare May 28, 2026 16:47
@melanieclarke

melanieclarke commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Regtests with jwst on main:
https://github.com/spacetelescope/RegressionTests/actions/runs/26599712397

Regtests with jwst branch + stcal updates:
https://github.com/spacetelescope/RegressionTests/actions/runs/26588854461

All passing.

@melanieclarke melanieclarke marked this pull request as ready for review May 29, 2026 12:40
@melanieclarke melanieclarke requested a review from a team as a code owner May 29, 2026 12:40
@stscirij

stscirij commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Should we also add the 4 new NIRSPEC subarrays here, or should they go into a separate PR?

@melanieclarke

Copy link
Copy Markdown
Contributor Author

Should we also add the 4 new NIRSPEC subarrays here, or should they go into a separate PR?

I think we can make that a separate PR.

@braingram braingram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I consulted https://jira.stsci.edu/browse/APT-94701 for the subarray names but if there is a more definitive ticket let me know.

@melanieclarke

Copy link
Copy Markdown
Contributor Author

Thanks for cross-checking, @braingram.

@melanieclarke melanieclarke enabled auto-merge June 11, 2026 16:09
@melanieclarke melanieclarke merged commit 892e766 into spacetelescope:main Jun 11, 2026
21 of 22 checks passed
@melanieclarke melanieclarke deleted the jp-4313 branch June 11, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants