JP-4313: Add NRC superstripe subarrays#739
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 99 99
Lines 4619 4619
=======================================
Hits 4188 4188
Misses 431 431 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b5941a1 to
06bc081
Compare
|
Regtests with jwst on main: Regtests with jwst branch + stcal updates: All passing. |
|
Should we also add the 4 new NIRSPEC subarrays here, or should they go into a separate PR? |
I think we can make that a separate PR. |
braingram
left a comment
There was a problem hiding this comment.
Changes LGTM. I consulted https://jira.stsci.edu/browse/APT-94701 for the subarray names but if there is a more definitive ticket let me know.
|
Thanks for cross-checking, @braingram. |
Toward JP-4313
Add new subarray names for upcoming NIRCam superstripe modes
Also add
meta.exposure.read_timesto the core schema to allow specification of explicit read times for unevenly sampled readouts. This is needed to support jump detection and ramp fitting for in-frame reads of repeated substripes.Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change