Remove deprecated __call__ method#239
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 95.32% 95.34% +0.02%
==========================================
Files 37 37
Lines 3399 3414 +15
==========================================
+ Hits 3240 3255 +15
Misses 159 159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Regtests with this branch + spacetelescope/jwst#9548: Regtests are all passing. Downstream CI does not because there is a test that looks for the warning in jwst on main. |
|
Romancal regtests: |
|
Flagging this for Roman attention: @braingram Discussed this with Eddie, who signed off but was unsure if romancal/RRN would be impacted. |
braingram
left a comment
There was a problem hiding this comment.
LGTM. __call__ was deprecated in romancal 0.18.0 so any users should have been seeing warnings.
|
FWIW, I don't understand the failure of the romancal unit tests, but it seems more like a configuration issue with how they're being called than it does like anything related to this PR. |
|
I don't have permission to merge this because of the failures in the required CI tests. @zacharyburnett - looks like you're the only stpipe maintainer? |
Resolves JP-3490
Resolves RCAL-nnnn
Remove the deprecated
__call__method from stpipe steps.Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stpipe@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change