Skip to content

Remove deprecated __call__ method#239

Merged
braingram merged 3 commits into
spacetelescope:mainfrom
melanieclarke:jp-3490
Jun 17, 2025
Merged

Remove deprecated __call__ method#239
braingram merged 3 commits into
spacetelescope:mainfrom
melanieclarke:jp-3490

Conversation

@melanieclarke

@melanieclarke melanieclarke commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator

Resolves JP-3490
Resolves RCAL-nnnn

Remove the deprecated __call__ method from stpipe steps.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stpipe@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov

codecov Bot commented Jun 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.34%. Comparing base (0f3e1cf) to head (37c74ed).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   95.32%   95.34%   +0.02%     
==========================================
  Files          37       37              
  Lines        3399     3414      +15     
==========================================
+ Hits         3240     3255      +15     
  Misses        159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke

melanieclarke commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator Author

Regtests with this branch + spacetelescope/jwst#9548:
https://github.com/spacetelescope/RegressionTests/actions/runs/15686793575

Regtests are all passing. Downstream CI does not because there is a test that looks for the warning in jwst on main.
The python 3.13 tests are not passing because of the logging issue reported in spacetelescope/jwst#9544

@melanieclarke melanieclarke marked this pull request as ready for review June 16, 2025 19:41
@melanieclarke melanieclarke requested a review from a team as a code owner June 16, 2025 19:41
@melanieclarke melanieclarke requested a review from tapastro June 16, 2025 20:04
@melanieclarke

Copy link
Copy Markdown
Collaborator Author

@tapastro tapastro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapastro

Copy link
Copy Markdown
Collaborator

Flagging this for Roman attention: @braingram

Discussed this with Eddie, who signed off but was unsure if romancal/RRN would be impacted.

@braingram braingram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. __call__ was deprecated in romancal 0.18.0 so any users should have been seeing warnings.

@schlafly

Copy link
Copy Markdown
Collaborator

FWIW, I don't understand the failure of the romancal unit tests, but it seems more like a configuration issue with how they're being called than it does like anything related to this PR.

@melanieclarke

Copy link
Copy Markdown
Collaborator Author

I don't have permission to merge this because of the failures in the required CI tests. @zacharyburnett - looks like you're the only stpipe maintainer?

@braingram braingram merged commit ed311bf into spacetelescope:main Jun 17, 2025
21 of 29 checks passed
@melanieclarke melanieclarke deleted the jp-3490 branch June 17, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants