Move gc.collect to end of step run#303
Open
pllim wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 95.65% 95.35% -0.30%
==========================================
Files 35 35
Lines 3359 3359
==========================================
- Hits 3213 3203 -10
- Misses 146 156 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks. Did this impact memory usage? Also, would you run jwst and romancal regtests with this change? |
Contributor
Author
|
Started RTs. Links on OP. |
Collaborator
|
Thanks for running the regtests. They show no memory differences. Is there any benefit to making this change? |
Contributor
Author
🤷♀️ I will have to defer to @melanieclarke or @tapastro 's expertise on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #172
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)stpipe@git+https://github.com/pllim/stpipe.git@mv-collect)jwstregression test https://github.com/spacetelescope/RegressionTests/actions/runs/23512447498 (passed)romancalregression test https://github.com/spacetelescope/RegressionTests/actions/runs/23512476825 (passed)