Skip to content

Move gc.collect to end of step run#303

Open
pllim wants to merge 1 commit into
spacetelescope:mainfrom
pllim:mv-collect
Open

Move gc.collect to end of step run#303
pllim wants to merge 1 commit into
spacetelescope:mainfrom
pllim:mv-collect

Conversation

@pllim
Copy link
Copy Markdown
Contributor

@pllim pllim commented Mar 24, 2026

Closes #172

Tasks

@pllim pllim requested a review from a team as a code owner March 24, 2026 19:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.35%. Comparing base (3e3765b) to head (cae1281).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   95.65%   95.35%   -0.30%     
==========================================
  Files          35       35              
  Lines        3359     3359              
==========================================
- Hits         3213     3203      -10     
- Misses        146      156      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram
Copy link
Copy Markdown
Collaborator

Thanks. Did this impact memory usage?

Also, would you run jwst and romancal regtests with this change?

@pllim
Copy link
Copy Markdown
Contributor Author

pllim commented Mar 24, 2026

Started RTs. Links on OP.

@braingram
Copy link
Copy Markdown
Collaborator

Thanks for running the regtests. They show no memory differences. Is there any benefit to making this change?

@pllim
Copy link
Copy Markdown
Contributor Author

pllim commented Mar 25, 2026

Is there any benefit to making this change?

🤷‍♀️

I will have to defer to @melanieclarke or @tapastro 's expertise on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move gc.collect call to end of Step.run

2 participants