Jax intro notebook#67
Open
arjunsavel wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
@snbianco first notebook here if you happen to be interested in taking a look! |
Contributor
|
Hey Arjun, sorry that I'm late in reviewing this! I took some vacation time over Labor Day. Overall, I think this is a strong notebook that's clear, to-the-point, and progresses logically. I also appreciate you being transparent about certain caveats. Here are a few notes I had for review:
|
Collaborator
|
I pushed a few of the typo fixes to the latest commit. I'll also emphasize three of Sam's comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cover...
Curious to hear thoughts on whether I move through these topics too quickly!