fix: clone spack to specific commit - #49
Open
wdconinc wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Pins the Spack clone used by the scheduled UI/package-data update workflow to a specific upstream commit, reducing the risk of unexpected breakages from changes on Spack’s default branch.
Changes:
- Clone Spack and hard-reset it to a fixed commit hash (with date comment) before running the update script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
15
to
+18
| - name: Clone development branch of spack | ||
| run: git clone https://github.com/spack/spack /opt/spack | ||
| run: | | ||
| git clone https://github.com/spack/spack /opt/spack | ||
| git -C /opt/spack reset --hard e2c5745352ebc0465ebc8d548e60759f05173c83 # Jul 28, 2026 |
Contributor
Author
|
Maybe could use: then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the update script to use a specific commit to avoid unintended breakage through changes in core. We can't write outside GITHUB_WORKSPACE with regulars like actions/checkout, so this remains a run step. We don't have weekly tags on spack/spack anymore, so this is a commit hash with date as comment.