Collect baseline job costs #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled from #93 to collect data before deciding on final cost formula. Adds the following columns: - nodes: AWS zone (`zone`) - nodes: Instance capacity type (`capacity_type`) - jobs: Cost of the instance during the lifetime of the job (`job_cost_instance`) The `job_cost_instance` calculation is made by averaging the value of `karpenter_cloudprovider_instance_type_offering_price_estimate` during the lifetime of the node and multiplying by the duration of the build job. **This is not a cost per job metric.** Use information like cpu_mean, mem_mean, etc to calculate the cost of the job in combination with `job_cost_instance`. tested with `dev/bulk_collect.py` and verified that large migrations work correctly on the prod and staging db
|
This PR looks good to me. Do we need to store the cost of the node in the job? Or could we store the cost of the node in the node object and then calculate that later on for jobs based on their duration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #93 to collect data before deciding on final cost formula.
Adds the following columns:
zone)capacity_type)job_cost_instance)The
job_cost_instancecalculation is made by averaging the value ofkarpenter_cloudprovider_instance_type_offering_price_estimateduring the lifetime of the node and multiplying by the duration of the build job.This is not a cost per job metric. Use information like cpu_mean, mem_mean, etc to calculate the cost of the job in combination with
job_cost_instance.tested with
dev/bulk_collect.pyand verified that large migrations work correctly on the prod and staging db