Windows: Stop using PSScriptRoot#1315
Merged
kwryankrattiger merged 1 commit intospack:mainfrom Mar 11, 2026
Merged
Conversation
In some contexts PSScriptRoot is not set. So far given usage it appears to be safe, but in upcoming Gitlab updates, and for other runner configurations, this value isn't set during pre-script, and will break the pre-build behavior and prevent proper upload. Use HOME which is always set and writable Signed-off-by: John Parent <john.parent@kitware.com>
Contributor
Author
|
Can't tag reviewers so @zackgalbreath @kwryankrattiger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some contexts PSScriptRoot is not set. So far given usage it appears to be safe, but in upcoming Gitlab updates, and for other runner configurations, this value isn't set during pre-script, and will break the pre-build behavior and prevent proper upload.
Use HOME which is always set and writable