Scope down runner service account permissions - #1423
Merged
Conversation
Only the executor/manager (gitlab/runner) needs permissions to create and drive job pods. This removes pipeline/runner from the binding so build pods have no Kubernetes API access, and sets automountServiceAccountToken: false on that SA so a job has no token to present even if a binding is reintroduced by mistake. The manager SA and the pipeline/runner SA itself (which job pods still reference) are unchanged, so CI is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the executor/manager (gitlab/runner) needs permissions to create and drive job pods. This removes pipeline/runner from the binding so build pods have no Kubernetes API access, and sets automountServiceAccountToken: false on that SA so a job has no token to present even if a binding is reintroduced by mistake. The manager SA and the pipeline/runner SA itself (which job pods still reference) are unchanged, so CI is unaffected.