Set up reproducible staging gitlab - #1434
Conversation
6305f6e to
9cc3462
Compare
mvandenburgh
left a comment
mvandenburgh
left a comment
There was a problem hiding this comment.
Some suggestions, though I don't think any are necessarily blocking for merging this - as long as these are accurately reflecting the state of staging, it does what we need it to for recreating the staging cluster.
Plus, I'd like to revisit this entire configuration after we recreate staging, to see if there's opportunities to consolidate these resouces into the spack_gitlab module for cleaner reuse between production and staging.
|
|
||
| provider "gitlab" { | ||
| base_url = "https://gitlab.staging.spack.io" | ||
| token = var.gitlab_token | ||
| } |
There was a problem hiding this comment.
Is this needed? It wasn't there before, and it production doesn't have it either.
| PR_MIRROR_FETCH_DOMAIN = "s3://spack-binaries-prs-staging" | ||
| PR_MIRROR_PUSH_DOMAIN = "s3://spack-binaries-prs-staging" | ||
| PROTECTED_MIRROR_FETCH_DOMAIN = "s3://spack-binaries-staging" | ||
| PROTECTED_MIRROR_PUSH_DOMAIN = "s3://spack-binaries-staging" |
There was a problem hiding this comment.
We could add these buckets to https://github.com/spack/spack-infrastructure/blob/main/terraform/modules/spack_aws_k8s/outputs.tf, and then reference them using variables instead of hardcoding.
2 participants
No description provided.