Skip to content

Comments

dyninst: patch missing cstdint includes#3479

Open
pearzt wants to merge 2 commits intospack:developfrom
pearzt:dyninst-patch-cstdint-include
Open

dyninst: patch missing cstdint includes#3479
pearzt wants to merge 2 commits intospack:developfrom
pearzt:dyninst-patch-cstdint-include

Conversation

@pearzt
Copy link
Contributor

@pearzt pearzt commented Feb 18, 2026

Building DynInst with GCC 15 currently fails as cstdint is no longer included by default. With this PR, I propose to add a patch to pulls in a commit from master that adds the missing include.

@spackbot-triage spackbot-triage bot requested a review from hainest February 18, 2026 15:51
@pearzt pearzt marked this pull request as draft February 18, 2026 15:52
@pearzt
Copy link
Contributor Author

pearzt commented Feb 18, 2026

Ah, opening this PR was a bit premature, as there seems to be another build problem with GCC 15. I will update this when I have a fix.

@pearzt pearzt force-pushed the dyninst-patch-cstdint-include branch from 3dea1ee to 8c4e1e2 Compare February 19, 2026 10:40
@pearzt
Copy link
Contributor Author

pearzt commented Feb 19, 2026

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Feb 19, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link

spackbot-app bot commented Feb 19, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/build_systems/go.py
repos/spack_repo/builtin/packages/acts/package.py
repos/spack_repo/builtin/packages/aocc/package.py
repos/spack_repo/builtin/packages/apple_glu/package.py
repos/spack_repo/builtin/packages/binutils/package.py
repos/spack_repo/builtin/packages/duckdb/package.py
repos/spack_repo/builtin/packages/dyninst/package.py
repos/spack_repo/builtin/packages/fpm/package.py
repos/spack_repo/builtin/packages/hugo/package.py
repos/spack_repo/builtin/packages/lammps/package.py
repos/spack_repo/builtin/packages/libmetatensor_torch/package.py
repos/spack_repo/builtin/packages/libmetatomic_torch/package.py
repos/spack_repo/builtin/packages/lmod/package.py
repos/spack_repo/builtin/packages/mesa/package.py
repos/spack_repo/builtin/packages/mesa_glu/package.py
repos/spack_repo/builtin/packages/node_js/package.py
repos/spack_repo/builtin/packages/openglu/package.py
repos/spack_repo/builtin/packages/openmpi/package.py
repos/spack_repo/builtin/packages/py_keras/package.py
repos/spack_repo/builtin/packages/py_metatensor_torch/package.py
repos/spack_repo/builtin/packages/py_metatomic_torch/package.py
repos/spack_repo/builtin/packages/py_pandas/package.py
repos/spack_repo/builtin/packages/py_snakemake_storage_plugin_fs/package.py
repos/spack_repo/builtin/packages/py_torchgeo/package.py
repos/spack_repo/builtin/packages/py_torchmetrics/package.py
repos/spack_repo/builtin/packages/r_rcpp/package.py
repos/spack_repo/builtin/packages/tcl/package.py
repos/spack_repo/builtin/packages/zlib/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@pearzt pearzt changed the title dyninst: patch missing cstdint include dyninst: patch missing cstdint includes Feb 19, 2026
@pearzt pearzt marked this pull request as ready for review February 19, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant