Skip to content

Comments

mesa: don't build llvmpipe when ~llvm#3499

Open
wdconinc wants to merge 2 commits intodevelopfrom
824-installation-issue-gtkplus-fails-to-build
Open

mesa: don't build llvmpipe when ~llvm#3499
wdconinc wants to merge 2 commits intodevelopfrom
824-installation-issue-gtkplus-fails-to-build

Conversation

@wdconinc
Copy link
Contributor

This PR modifies mesa to reflect https://gitlab.freedesktop.org/mesa/mesa/-/commit/010b2f9497a. swrast was (removed since then) an alias for softpipe and llvmpipe. When ~llvm, the configuration with llvmpipe fails (see e.g. #824 (comment)).

Note: There may be other ways to support this (e.g. instead of adding swrast by default, we could add both llvmpipe and softpipe explicitly), but I'm trying to apply a minimal fix to the issue at hand.

Copilot AI review requested due to automatic review settings February 20, 2026 19:11
@wdconinc wdconinc linked an issue Feb 20, 2026 that may be closed by this pull request
4 tasks
@spackbot-triage spackbot-triage bot requested a review from v-dobrev February 20, 2026 19:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a build failure in mesa when built without LLVM support by conditionally selecting gallium drivers based on the llvm variant. The change reflects an upstream mesa commit (010b2f9497a) that clarifies the relationship between swrast, softpipe, and llvmpipe drivers.

Changes:

  • Adds conditional logic to select "swrast" gallium drivers when +llvm variant is enabled
  • Uses "softpipe" alone when ~llvm variant is specified (since llvmpipe requires LLVM)
  • Adds a comment explaining that swrast includes both softpipe and llvmpipe

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation issue: gtkplus fails to build

1 participant