Open
Conversation
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a build failure in mesa when built without LLVM support by conditionally selecting gallium drivers based on the llvm variant. The change reflects an upstream mesa commit (010b2f9497a) that clarifies the relationship between swrast, softpipe, and llvmpipe drivers.
Changes:
- Adds conditional logic to select "swrast" gallium drivers when
+llvmvariant is enabled - Uses "softpipe" alone when
~llvmvariant is specified (since llvmpipe requires LLVM) - Adds a comment explaining that swrast includes both softpipe and llvmpipe
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
mesato reflect https://gitlab.freedesktop.org/mesa/mesa/-/commit/010b2f9497a.swrastwas (removed since then) an alias forsoftpipeandllvmpipe. When~llvm, the configuration withllvmpipefails (see e.g. #824 (comment)).Note: There may be other ways to support this (e.g. instead of adding
swrastby default, we could add bothllvmpipeandsoftpipeexplicitly), but I'm trying to apply a minimal fix to the issue at hand.