VTK: model scnlib dependency required for building 9.5 and newer#3502
Open
johnwparent wants to merge 2 commits intospack:developfrom
Open
VTK: model scnlib dependency required for building 9.5 and newer#3502johnwparent wants to merge 2 commits intospack:developfrom
johnwparent wants to merge 2 commits intospack:developfrom
Conversation
Enforce use of external scn Signed-off-by: John Parent <john.parent@kitware.com>
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/vtk/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
| cmake_args.extend( | ||
| [ | ||
| "-DVTK_MODULE_USE_EXTERNAL_VTK_vtkviskores:BOOL=OFF", | ||
| "-DVTK_MODULE_USE_EXTERNAL_VTK_scn:BOOL=ON", |
Contributor
There was a problem hiding this comment.
Is this not already covered by setting external by default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally enforce use of external scn
cc @Chrismarsh