Skip to content

Adding Kokkos Comm recipe#5078

Draft
cedricchevalier19 wants to merge 5 commits into
spack:developfrom
cedricchevalier19:kokkos-comm
Draft

Adding Kokkos Comm recipe#5078
cedricchevalier19 wants to merge 5 commits into
spack:developfrom
cedricchevalier19:kokkos-comm

Conversation

@cedricchevalier19
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Cedric Chevalier <cedric.chevalier@cea.fr>
Signed-off-by: Cedric Chevalier <cedric.chevalier@cea.fr>
Signed-off-by: Cedric Chevalier <cedric.chevalier@cea.fr>
Signed-off-by: Cedric Chevalier <cedric.chevalier@cea.fr>
Signed-off-by: Cedric Chevalier <cedric.chevalier@cea.fr>
@cedricchevalier19
Copy link
Copy Markdown
Contributor Author

@spackbot style --fix

# Mandatory dependencies
depends_on("cxx")
depends_on("c", when="+mpi")
depends_on("cmake@3.22:3", type="build")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kokkos Comm requires CMake 3.25 since kokkos-comm#212.
Any CMake 4+ works correctly as well, so we can afford not to put a bound on the maximum supported version.

Suggested change
depends_on("cmake@3.22:3", type="build")
depends_on("cmake@3.25:", type="build")


def cmake_args(self):
args = [
self.define("KokkosComm_ENABLE_MPI", "mpi"),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define_from_variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants