Skip to content

r: prevent invalid substitution of paths in LDFLAGS - #6080

Open
w8jcik wants to merge 1 commit into
spack:developfrom
w8jcik:fix-r-ldflags
Open

r: prevent invalid substitution of paths in LDFLAGS#6080
w8jcik wants to merge 1 commit into
spack:developfrom
w8jcik:fix-r-ldflags

Conversation

@w8jcik

@w8jcik w8jcik commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Resolves #6078

@spackbot-triage spackbot-triage Bot added R update-package Modifications to packages in the repository labels Aug 13, 2026
bernhardkaindl
bernhardkaindl previously approved these changes Aug 13, 2026

@bernhardkaindl bernhardkaindl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w8jcik, as you're the expert working on it, I trust you.

@bernhardkaindl

Copy link
Copy Markdown
Contributor

@w8jcik, should I enable auto-merge already?

@w8jcik

w8jcik commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

as you're the expert working on it, I trust you.

Haha, thanks =)

I belive that the fix works.

should I enable auto-merge already?

I would wait one day for some of my builds to finish to confirm that this has no adverse side-effects.

@bernhardkaindl

bernhardkaindl commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

I would wait one day for some of my builds to finish to confirm that this has no adverse side-effects.

Good, I'll only be sporadically available from now on.

When ready for merge, ping me on Github using a

@bernhardkaindl ready for merge / please merge thanks!

(or so, just a clear direct message if to act), then I'll merge when you see your message.

Otherwise you've to ask someone else who is approving PRs and can merge them (wdconinc, alecbcs, RikkiButler20)

I'll be mostly offline for quite some time, so I ping one of the mainainers to review or send a RFR with the link to #pull-requests in the Spack workspace https://spackpm.slack.com.

@w8jcik

w8jcik commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the heads up and for your work.

Good, I'll only be sporadically available from now on.

Hope it is some nice holiday. In such case enjoy.

@w8jcik

w8jcik commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

I can confirm that this fix works and the pull request can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Substitution in R package recipe produces invalid LDFLAGS when R installation hash starts with "lz"

2 participants