busco: Added versions, miniprot dependency - #6089
Open
emwjacobson wants to merge 2 commits into
Open
Conversation
snehring
suggested changes
Aug 14, 2026
| depends_on("prodigal", when="@5:", type="run") | ||
| depends_on("metaeuk", when="@5:", type="run") | ||
| depends_on("sepp", when="@5:", type="run") | ||
| depends_on("miniprot", when="@5.6:", type="run") |
Contributor
There was a problem hiding this comment.
It looks like 5.6.0 also added a dependency for py-requests
Suggested change
| depends_on("miniprot", when="@5.6:", type="run") | |
| depends_on("miniprot", when="@5.6:", type="run") | |
| depends_on("py-requests", when="@5.6:", type="run") |
I don't see any other obvious added deps, but I'm not infallible.
Contributor
|
numpy's already implicit with biopython, but I'm good with being explicit. Are you sure about some of the versions you've changed? I don't think prodigal was included until 5.0., same with sepp. |
Contributor
Author
|
I could have sworn that I made a comment addressing the changed, but I guess I didn't actually send it... weird. I'll be honest that I had Claude attempt to do most of the digging here, but I did my best to to verify the usages:
|
Contributor
|
You're probably correct. I was running off the commit history of the wrappers, it's possible they didn't start doing it that way until 5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of version 5.6 of Busco, miniprot is added as a dependency. Added the latest point release of each minor version as well.
Maintainer is listed as @snehring