Skip to content

busco: Added versions, miniprot dependency - #6089

Open
emwjacobson wants to merge 2 commits into
spack:developfrom
emwjacobson:busco-update
Open

busco: Added versions, miniprot dependency#6089
emwjacobson wants to merge 2 commits into
spack:developfrom
emwjacobson:busco-update

Conversation

@emwjacobson

Copy link
Copy Markdown
Contributor

As of version 5.6 of Busco, miniprot is added as a dependency. Added the latest point release of each minor version as well.

Maintainer is listed as @snehring

@spackbot-triage spackbot-triage Bot added new-version Modifications to packages' `depends_on()` directives dependencies Modifications with a `depends_on()` directive update-package Modifications to packages in the repository labels Aug 13, 2026
depends_on("prodigal", when="@5:", type="run")
depends_on("metaeuk", when="@5:", type="run")
depends_on("sepp", when="@5:", type="run")
depends_on("miniprot", when="@5.6:", type="run")

@snehring snehring Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 5.6.0 also added a dependency for py-requests

Suggested change
depends_on("miniprot", when="@5.6:", type="run")
depends_on("miniprot", when="@5.6:", type="run")
depends_on("py-requests", when="@5.6:", type="run")

I don't see any other obvious added deps, but I'm not infallible.

@snehring

Copy link
Copy Markdown
Contributor

numpy's already implicit with biopython, but I'm good with being explicit. Are you sure about some of the versions you've changed? I don't think prodigal was included until 5.0., same with sepp.

@emwjacobson

Copy link
Copy Markdown
Contributor Author

I could have sworn that I made a comment addressing the changed, but I guess I didn't actually send it... weird.

I'll be honest that I had Claude attempt to do most of the digging here, but I did my best to to verify the usages:

@snehring

Copy link
Copy Markdown
Contributor

You're probably correct. I was running off the commit history of the wrappers, it's possible they didn't start doing it that way until 5.0.

@snehring snehring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Modifications with a `depends_on()` directive new-version Modifications to packages' `depends_on()` directives update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants