Skip to content

r-s4vectors: add conflicts; r-delayedarray: add conflicts - #6092

Open
w8jcik wants to merge 1 commit into
spack:developfrom
w8jcik:add-r-s4vectors-r-delayedarray-conflicts
Open

r-s4vectors: add conflicts; r-delayedarray: add conflicts#6092
w8jcik wants to merge 1 commit into
spack:developfrom
w8jcik:add-r-s4vectors-r-delayedarray-conflicts

Conversation

@w8jcik

@w8jcik w8jcik commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Before

image image

After

image image

@spackbot-triage spackbot-triage Bot added R update-package Modifications to packages in the repository conflicts Modifications with a `conflicts()` directive labels Aug 14, 2026
@w8jcik

w8jcik commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app

spackbot-app Bot commented Aug 14, 2026

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented Aug 14, 2026

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/r_delayedarray/package.py
repos/spack_repo/builtin/packages/r_s4vectors/package.py
�[1;34m==> �[0mrunning ruff format
2 files left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (107 > 99)�[0m
  �[1m�[94m-->�[0m repos/spack_repo/builtin/packages/r_delayedarray/package.py:90:100
   �[1m�[94m|�[0m
�[1m�[94m89 |�[0m     # > Error in matchSignature(signature, fdef, where) :
�[1m�[94m90 |�[0m     #     more elements in the method signature (2) than in the generic signature (1) for function 'type<-'
   �[1m�[94m|�[0m                                                                                                    �[1m�[91m^^^^^^^^�[0m
�[1m�[94m91 |�[0m     conflicts("^r-biocgenerics@0.44:", when="@:0.22")
   �[1m�[94m|�[0m

�[1m�[91mE501 �[0m�[1mLine too long (106 > 99)�[0m
  �[1m�[94m-->�[0m repos/spack_repo/builtin/packages/r_s4vectors/package.py:52:100
   �[1m�[94m|�[0m
�[1m�[94m50 |�[0m     depends_on("r-biocgenerics@0.21.1:", type=("build", "run"))
�[1m�[94m51 |�[0m
�[1m�[94m52 |�[0m     # > Error: package or namespace load failed for 'S4Vectors' in dyn.load(file, DLLpath = DLLpath, ...):
   �[1m�[94m|�[0m                                                                                                    �[1m�[91m^^^^^^^�[0m
�[1m�[94m53 |�[0m     #    unable to load shared object 'S4Vectors.so': ... undefined symbol: PREXPR
�[1m�[94m54 |�[0m     conflicts("^r@4.6:", when="@:0.46")
   �[1m�[94m|�[0m

Found 2 errors.
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally!

@w8jcik
w8jcik force-pushed the add-r-s4vectors-r-delayedarray-conflicts branch 4 times, most recently from a10c30a to af67327 Compare August 14, 2026 17:59
@w8jcik w8jcik changed the title r-s4vectors: add conflicts with r and r-biocgenerics; r-delayedarray: add conflicts with r-biocgenerics r-s4vectors: add conflicts with r and r-biocgenerics; r-delayedarray: add conflicts with r-biocgenerics and r-s4vectors Aug 14, 2026
@w8jcik
w8jcik force-pushed the add-r-s4vectors-r-delayedarray-conflicts branch from af67327 to cd52fcd Compare August 14, 2026 18:00
@w8jcik
w8jcik force-pushed the add-r-s4vectors-r-delayedarray-conflicts branch from cd52fcd to ac3f35d Compare August 14, 2026 18:10
@w8jcik w8jcik changed the title r-s4vectors: add conflicts with r and r-biocgenerics; r-delayedarray: add conflicts with r-biocgenerics and r-s4vectors r-s4vectors: add conflicts; r-delayedarray: add conflicts Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts Modifications with a `conflicts()` directive R update-package Modifications to packages in the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant