shapelib: add tests variant - #6093
Open
mathomp4 wants to merge 1 commit into
Open
Conversation
spackbot-triage
Bot
added
update-package
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In doing a build test on an air-gapped node where I'd pre-fetched my sources, I found I couldn't build
shapelib. By default, their CMake seems to enable testing as long asbashcan be found (see https://github.com/OSGeo/shapelib/blob/6e3ac42088274d3a68c0c35aa42e0ddf7f80104e/CMakeLists.txt#L207-L213).This then triggers a
FetchContentcall to download Google benchmark and GoogleTest which weren't prefetched and crash.So this PR adds a
testsvariant which defaults to False.