Add proper support for ? operator#3
Merged
spanishpear merged 2 commits intospanishpear:mainfrom Oct 13, 2025
Merged
Conversation
spanishpear
approved these changes
Oct 13, 2025
Owner
spanishpear
left a comment
There was a problem hiding this comment.
this seems sensible and well tested. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be some undocumented behaviour that Yarn engages in, where for very long descriptor lines in a lockfile, it will prefix them with a
?character and then place the:on a new line before the rest of the package info. For example:Right now, this isn't supported by this crate - these entries just get kind of skipped over and blended with the next entry in the lockfile. This is because
nomtries to parse this with theparser, which partially succeeds but isn't expecting a newline before the
:. This PR fixes this issue by checking for the?indicator and using a different parser to correctly handle the situation.