Skip to content

Resolve descriptor handling bug introduced in 0.5#6

Merged
spanishpear merged 8 commits intomainfrom
spanishpear/js-comparisons
Dec 2, 2025
Merged

Resolve descriptor handling bug introduced in 0.5#6
spanishpear merged 8 commits intomainfrom
spanishpear/js-comparisons

Conversation

@spanishpear
Copy link
Copy Markdown
Owner

0.5 release caused some customers to fail - seems we dropped some handling of ranges

Thanks to the internal validator I found a few minor differences - mostly around us dropping descriptors

this PR adds a comparison to the yarnpkg parser (quick hacky script) and resolves this main issue reported.

Looking at the differences, I can see the issue: berry parser is outputting descriptors without the npm: prefix (e.g., "redent@^3.0.0"), while the JS output has npm: (e.g., "redent@npm:^3.0.0").

we also add tests for backwards compat, and fix some broken fixtures.

@spanishpear spanishpear changed the title test comparison and removing differences Resolve descriptor handling bug introduced in 0.5 Dec 1, 2025
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super scuffed i know

@spanishpear spanishpear marked this pull request as ready for review December 2, 2025 01:04
@spanishpear spanishpear merged commit ad60d90 into main Dec 2, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants