feat(BLDL23): automate browser extension packaging #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Extension packages built successfully! |
MLKendall
force-pushed
the
bldl-23--automate-browser-extension-packaging
branch
2 times, most recently
from
1e6a02c to
a607dd6
Compare
MLKendall
force-pushed
the
bldl-23--automate-browser-extension-packaging
branch
from
a607dd6 to
9a8637a
Compare
dustin-jw
requested changes
Oct 21, 2025
.github/workflows/build.yml
Outdated
Comment on lines
19
to
20
| # Continue on error to ensure we always get some output | ||
| continue-on-error: false |
Contributor
There was a problem hiding this comment.
Don't need to set this if we're not continuing on error.
.github/workflows/build.yml
Outdated
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "18" |
Contributor
There was a problem hiding this comment.
LTS is 22, let's use that.
.github/workflows/build.yml
Outdated
Comment on lines
38
to
39
| - name: Validate Firefox modifications | ||
| run: node -e "const m=JSON.parse(require('fs').readFileSync('build/firefox/manifest.json','utf8')); if(!m.background.scripts||!m.browser_specific_settings?.gecko||m.background.service_worker) {console.error('❌ Firefox manifest missing required modifications or still has service_worker'); process.exit(1);} console.log('✅ Firefox manifest properly modified')" |
Contributor
There was a problem hiding this comment.
This seems incredibly brittle to me, better to write tests or do this error checking in the build script than to do this check on every build.
.github/workflows/build.yml
Outdated
Comment on lines
55
to
60
| - name: Upload build directory artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: build-directory | ||
| path: build/ | ||
| retention-days: 30 |
Contributor
There was a problem hiding this comment.
We can most likely do without saving the entire build directory. The two zip files for Chrome/Firefox should be sufficient.
dustin-jw
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GitHub Actions workflow that automatically builds extension packages on every push to main and pull requests. The workflow installs dependencies, runs the build script, validates Firefox compatibility (ensuring proper manifest conversion from Chrome Manifest V3 to Firefox format), and uploads both Chrome and Firefox .zip files as build artifacts.
To Validate: