Skip to content

refs platform#3822: update Docker-in-Docker image configuration#312

Merged
FabrizioCafolla merged 10 commits into
masterfrom
fix/3822-error-artifact-registry
Sep 10, 2025
Merged

refs platform#3822: update Docker-in-Docker image configuration#312
FabrizioCafolla merged 10 commits into
masterfrom
fix/3822-error-artifact-registry

Conversation

@FabrizioCafolla

@FabrizioCafolla FabrizioCafolla commented Sep 9, 2025

Copy link
Copy Markdown
Member

PR Type

Enhancement


Description

  • Replace hardcoded Docker-in-Docker image with configurable variables

  • Add new DOCKER_DIND_IMAGE_* variables for registry, repository, and tag

  • Enable customization of dind service image in GitLab CI template

  • Improve template flexibility and maintainability


Changes walkthrough 📝

Relevant files
Configuration changes
.gitlab-ci-template.yml
Parameterize Docker-in-Docker service image configuration

templates/.gitlab-ci-template.yml

  • Replace hardcoded docker:26.1.0-dind-alpine3.19 with variable-based
    image reference
  • Add three new variables: DOCKER_DIND_IMAGE_REGISTRY,
    DOCKER_DIND_IMAGE_REPOSITORY, DOCKER_DIND_IMAGE_TAG
  • Include documentation comments explaining the new dind image
    configuration variables
  • +7/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @sparkfabrik-ai-bot

    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Alias

    The Docker-in-Docker service configuration is missing an alias definition, which may cause issues with service discovery and communication between containers in the GitLab CI pipeline.

    - name: ${DOCKER_DIND_IMAGE_REGISTRY}/${DOCKER_DIND_IMAGE_REPOSITORY}:${DOCKER_DIND_IMAGE_TAG}

    @sparkfabrik-ai-bot

    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @FabrizioCafolla FabrizioCafolla merged commit df22753 into master Sep 10, 2025
    2 checks passed
    @FabrizioCafolla FabrizioCafolla deleted the fix/3822-error-artifact-registry branch September 10, 2025 09:18
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants