Remove deprecated launchd/com.sparkfabrik.sparkdock.plist file#131
Merged
Conversation
Co-authored-by: paolomainardi <8747+paolomainardi@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated LaunchAgent configuration files that are no longer needed due to the introduction of a new Swift-based menubar app for update notifications.
- Removes the deprecated
launchd/com.sparkfabrik.sparkdock.plistLaunchAgent file that scheduled periodic update checks - Removes the now-empty
launchd/directory from the repository - Completes the transition from scheduled shell script updates to the modern menubar app approach
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Copilot
AI
changed the title
[WIP] launchd/com.sparkfabrik.sparkdock.plist remove this legacy file
Remove deprecated launchd/com.sparkfabrik.sparkdock.plist file
Aug 18, 2025
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
paolomainardi
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
launchd/com.sparkfabrik.sparkdock.plistfile and its containing directory, which are no longer needed since the introduction of the new menubar app.Background
The legacy LaunchAgent plist file was used to schedule periodic update checks for Sparkdock through the old update mechanism. This has been superseded by the new Swift-based menubar application that provides real-time update notifications and better user experience.
Changes
launchd/com.sparkfabrik.sparkdock.plist- legacy LaunchAgent configurationlaunchd/directoryVerification
The removal is safe because:
ansible/macos/macos/base.ymlexplicitly removes this file from user systems when installing the new menubar app (line 423)com.sparkfabrik.sparkdock.menubar.plistwith improved functionalityThe old plist scheduled weekly update checks, while the new menubar app provides event-driven updates triggered by system wake and network changes, offering better responsiveness and battery efficiency.
Fixes #130.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
PR Type
Other
Description
Remove deprecated
launchd/com.sparkfabrik.sparkdock.plistfileClean up legacy LaunchAgent configuration
File replaced by new menubar app implementation
Ansible already handles removal during installation
Changes walkthrough 📝
com.sparkfabrik.sparkdock.plist
Remove deprecated LaunchAgent plist filelaunchd/com.sparkfabrik.sparkdock.plist