Skip to content

feat: just print version#142

Merged
paolomainardi merged 1 commit into
masterfrom
feature/140_revert_print_versions
Aug 18, 2025
Merged

feat: just print version#142
paolomainardi merged 1 commit into
masterfrom
feature/140_revert_print_versions

Conversation

@paolomainardi

@paolomainardi paolomainardi commented Aug 18, 2025

Copy link
Copy Markdown
Member

User description

closes #140


PR Type

Bug fix


Description

  • Simplify version display to show single current version

  • Remove remote version fetching that always matched local

  • Fix misleading version information in system banner

  • Rename variable from local_version to current_version


Changes walkthrough 📝

Relevant files
Bug fix
utils.sh
Simplify version display logic                                                     

bin/common/utils.sh

  • Remove remote version fetching logic that always matched local version
  • Simplify output to show single version instead of local/remote pair
  • Rename local_version variable to current_version for clarity
  • Remove git fetch operation that was causing confusion
  • +2/-9     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copilot AI review requested due to automatic review settings August 18, 2025 21:10

    Copilot AI left a comment

    Copy link
    Copy Markdown
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Copilot wasn't able to review any files in this pull request.


    You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

    @paolomainardi paolomainardi merged commit 31f4457 into master Aug 18, 2025
    3 checks passed
    @sparkfabrik-ai-bot

    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    140 - PR Code Verified

    Compliant requirements:

    • Fix the issue where local and remote versions are always the same in system banner
    • Remove the misleading version information that shows identical local and remote versions

    Requires further human verification:

    • Verify that the new single version display format matches user expectations
    • Test that the system banner output is clear and informative
    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Validation

    The function changes directory to /opt/sparkdock without preserving the original working directory, which could affect the calling context if the function fails or is interrupted

    cd /opt/sparkdock

    @sparkfabrik-ai-bot

    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Local and remote version are always the same on the system banner

    2 participants