fix: better check-updates logging

[paolomainardi]

PR Type

Bug fix

---

Description

• Improved update checking logic in macOS script

• Added validation for git log output

• Enhanced logging reliability for available updates

• Fixed potential empty output display issues

---

Changes walkthrough 📝

	Relevant files
Bug fix	sparkdock.macos Improve update checking output validation                                bin/sparkdock.macos Store git log output in DIFF variable before displaying Add check to ensure DIFF is not empty before showing updates Prevent display of empty update messages +5/-2

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[Copilot]

Copilot wasn't able to review any files in this pull request.

[sparkfabrik-ai-bot]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Logic Issue The validation check for git log output may prevent legitimate updates from being displayed. If git log returns empty output (no commits between HEAD and origin branch), the function will still return 0 indicating updates are available, but won't display anything to the user, creating inconsistent behavior. DIFF=$(git --no-pager log --oneline HEAD..origin/${DEFAULT_BRANCH}) if [ -n "$DIFF" ]; then echo "Updates available:" echo "$DIFF" fi

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Remove redundant empty check The additional check for non-empty DIFF is redundant since the outer condition already ensures LOCAL != REMOTE, which guarantees commits exist. This adds unnecessary complexity without providing value. bin/sparkdock.macos [48-52] -DIFF=$(git --no-pager log --oneline HEAD..origin/${DEFAULT_BRANCH}) -if [ -n "$DIFF" ]; then - echo "Updates available:" - echo "$DIFF" -fi +echo "Updates available:" +git --no-pager log --oneline HEAD..origin/${DEFAULT_BRANCH} Suggestion importance[1-10]: 4 __ Why: The suggestion is technically correct that LOCAL != REMOTE implies commits exist, but the additional check for non-empty DIFF provides defensive programming and better error handling in edge cases where git commands might fail or return unexpected results.	Low