feat: place random hex before name in pool and provider IDs to avoid collisions#13
Merged
Merged
Conversation
FabrizioCafolla
approved these changes
May 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the Workload Identity Pool and Provider ID generation to place the random hex segment before var.name, reducing the chance of ID collisions when long names cause truncation. It also adds/updates documentation to describe the resulting breaking change and upgrade steps.
Changes:
- Change pool/provider ID format to
*-{hex}-{name}by introducing a dedicated local suffix and using it inmain.tf. - Add an upgrade guide for the 0.2.x → 1.0.0 breaking change.
- Update README/CHANGELOG content (including regenerated markdown tables) to reflect the release.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
main.tf |
Switch pool/provider IDs to use the new {hex}-{name} suffix to avoid truncation collisions. |
locals.tf |
Introduce resource_name_pool_suffix to support the new ID layout while keeping the old suffix for other resources. |
UPGRADING.md |
Add upgrade guidance and list impacted resources for the breaking ID change. |
CHANGELOG.md |
Document the 1.0.0 breaking change and link to the upgrade guide. |
README.md |
Reformat and refresh module documentation tables/examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…collisions Refs: sparkfabrik-innovation-team/board#4193 Assisted-by: opencode/github-copilot/claude-opus-4.6
Monska85
force-pushed
the
feat/4193-random-pool-id-prefix
branch
from
d4bd3ce to
88ea8bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: sparkfabrik-innovation-team/board#4193
Assisted-by: opencode/github-copilot/claude-opus-4.6