fix: add triggers to manage Cloud SQL proxy lifecycle

[filippolmt]

No description provided.

[Copilot]

Pull Request Overview

This PR adds explicit triggers blocks to the execute_cloud_sql_proxy and kill_cloud_sql_proxy null resources to ensure they respond to changes in permissions_refresh_id, improving the lifecycle management of Cloud SQL proxy operations when permissions need to be reapplied.

• Added triggers block with refresh_id = var.permissions_refresh_id to both proxy resources
• Updated CHANGELOG.md to document version 0.5.1 with these lifecycle improvements

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
main.tf	Added triggers blocks to execute_cloud_sql_proxy and kill_cloud_sql_proxy resources to track permissions_refresh_id changes
CHANGELOG.md	Added version 0.5.1 entry documenting the lifecycle management improvements

Comments suppressed due to low confidence (2)

main.tf:14

• The triggers block and replace_triggered_by create redundant tracking of the same condition. The null_resource.force_permissions_refresh already has triggers = { refresh_id = var.permissions_refresh_id } (line 74-76), so replace_triggered_by will trigger replacement when permissions_refresh_id changes. Adding an identical triggers block here creates double-tracking of the same variable. Consider removing the triggers block from execute_cloud_sql_proxy and relying solely on the replace_triggered_by mechanism for cleaner lifecycle management.

  triggers = {
    refresh_id = var.permissions_refresh_id
  }

  lifecycle {
    replace_triggered_by = [
      null_resource.force_permissions_refresh.id
    ]
  }

main.tf:134

• The triggers block and replace_triggered_by create redundant tracking of the same condition. The null_resource.force_permissions_refresh already has triggers = { refresh_id = var.permissions_refresh_id } (line 74-76), so replace_triggered_by will trigger replacement when permissions_refresh_id changes. Adding an identical triggers block here creates double-tracking of the same variable. Consider removing the triggers block from kill_cloud_sql_proxy and relying solely on the replace_triggered_by mechanism for cleaner lifecycle management.

  triggers = {
    refresh_id = var.permissions_refresh_id
  }

  lifecycle {
    replace_triggered_by = [
      null_resource.force_permissions_refresh.id
    ]
  }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Monska85]

LGTM 👍