Skip to content

feat: update module documentation#5

Merged
Monska85 merged 1 commit intomainfrom
feat/update_module_documentation
Sep 3, 2025
Merged

feat: update module documentation#5
Monska85 merged 1 commit intomainfrom
feat/update_module_documentation

Conversation

@Monska85
Copy link
Copy Markdown
Contributor

@Monska85 Monska85 commented Sep 2, 2025

PR Type

Documentation


Description

  • Update Cloud SQL monitoring configuration defaults

  • Change default severity levels from CRITICAL to WARNING

  • Adjust default threshold values for disk utilization

  • Add changelog entry for documentation updates


Changes walkthrough 📝

Relevant files
Documentation
CHANGELOG.md
Add changelog entry for documentation update                         

CHANGELOG.md

  • Add entry for module documentation update in unreleased section
+2/-0     
README.md
Update Cloud SQL monitoring configuration defaults             

README.md

  • Change default severity from CRITICAL to WARNING for CPU, memory, and
    disk utilization
  • Update default disk utilization threshold from 0.90 to 0.85
  • Remove some default threshold values in memory utilization examples
  • Adjust memory utilization CRITICAL threshold from 0.90 to 0.95
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @sparkfabrik-ai-bot
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Inconsistent Defaults

    The documentation shows inconsistent default values between the schema definition and example configurations. For cpu_utilization, the default severity is WARNING but the first example uses no severity (implying WARNING), while disk_utilization default threshold is 0.85 but the first example shows no threshold.

    | <a name="input_cloud_sql"></a> [cloud\_sql](#input\_cloud\_sql) | n/a | <pre>object({<br>    project               = optional(string, null)<br>    auto_close            = optional(string, null)<br>    notification_channels = optional(list(string), [])<br>    instances = optional(map(object({<br>      cpu_utilization = optional(list(object({<br>        severity         = optional(string, "WARNING"),<br>        threshold        = optional(number, 0.90)<br>        alignment_period = optional(string, "120s")<br>        duration         = optional(string, "300s")<br>        })), [<br>        {<br>          threshold = 0.85,<br>          duration  = "1200s",<br>        },<br>        {<br>          severity  = "CRITICAL",<br>          threshold = 1,<br>          duration  = "300s",<br>          alignment_period = "60s",<br>        }<br>      ])<br>      memory_utilization = optional(list(object({<br>        severity         = optional(string, "WARNING"),<br>        threshold        = optional(number, 0.90)<br>        alignment_period = optional(string, "300s")<br>        duration         = optional(string, "300s")<br>        })), [<br>        {<br>          severity  = "WARNING",<br>        },<br>        {<br>          severity  = "CRITICAL",<br>          threshold = 0.95,<br>        }<br>      ])<br>      disk_utilization = optional(list(object({<br>        severity         = optional(string, "WARNING"),<br>        threshold        = optional(number, 0.85)<br>        alignment_period = optional(string, "300s")<br>        duration         = optional(string, "600s")<br>        })), [<br>        {<br>          severity  = "WARNING",<br>        },<br>        {<br>          severity  = "CRITICAL",<br>          threshold = 0.95,          <br>        }<br>      ])<br>    })), {})<br>  })</pre> | n/a | yes |
    Missing Threshold

    In the memory_utilization first example configuration, the threshold value is missing while only severity is specified, which may cause confusion about what threshold value will be applied.

    | <a name="input_cloud_sql"></a> [cloud\_sql](#input\_cloud\_sql) | n/a | <pre>object({<br>    project               = optional(string, null)<br>    auto_close            = optional(string, null)<br>    notification_channels = optional(list(string), [])<br>    instances = optional(map(object({<br>      cpu_utilization = optional(list(object({<br>        severity         = optional(string, "WARNING"),<br>        threshold        = optional(number, 0.90)<br>        alignment_period = optional(string, "120s")<br>        duration         = optional(string, "300s")<br>        })), [<br>        {<br>          threshold = 0.85,<br>          duration  = "1200s",<br>        },<br>        {<br>          severity  = "CRITICAL",<br>          threshold = 1,<br>          duration  = "300s",<br>          alignment_period = "60s",<br>        }<br>      ])<br>      memory_utilization = optional(list(object({<br>        severity         = optional(string, "WARNING"),<br>        threshold        = optional(number, 0.90)<br>        alignment_period = optional(string, "300s")<br>        duration         = optional(string, "300s")<br>        })), [<br>        {<br>          severity  = "WARNING",<br>        },<br>        {<br>          severity  = "CRITICAL",<br>          threshold = 0.95,<br>        }<br>      ])<br>      disk_utilization = optional(list(object({<br>        severity         = optional(string, "WARNING"),<br>        threshold        = optional(number, 0.85)<br>        alignment_period = optional(string, "300s")<br>        duration         = optional(string, "600s")<br>        })), [<br>        {<br>          severity  = "WARNING",<br>        },<br>        {<br>          severity  = "CRITICAL",<br>          threshold = 0.95,          <br>        }<br>      ])<br>    })), {})<br>  })</pre> | n/a | yes |

    @sparkfabrik-ai-bot
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Monska85 Monska85 merged commit c7df9b6 into main Sep 3, 2025
    1 check passed
    @Monska85 Monska85 deleted the feat/update_module_documentation branch September 3, 2025 08:19
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants