[#194]: Support offset in Search requests #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgepyne
changed the title
captaincoordinates
requested changes
Nov 12, 2025
Collaborator
captaincoordinates
left a comment
captaincoordinates
left a comment
There was a problem hiding this comment.
PR looks great, just a couple minor comments - one of which you're welcome to disregard.
| assert next_result["features"][0]["id"] == _all_items[offset + limit]["id"] | ||
|
|
||
|
|
||
| def test_post_search_offset_exceeds_total() -> None: |
Collaborator
There was a problem hiding this comment.
Seems like this test should be replicated in the GET search test module?
Collaborator
Author
There was a problem hiding this comment.
I will update the tests to replicate with GET search also
| ) | ||
|
|
||
| def _get_offset_from_request(self) -> Optional[int]: | ||
| offset_value = cast(Optional[int], getattr(self.search_request, "offset", None)) |
Collaborator
There was a problem hiding this comment.
I think a slightly different approach could communicate intent more clearly, e.g.
offset_value = cast(POSTOffsetPagination, self.search_request).offset
but both approaches get the job done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OffsetPaginationExtensionthat exposes validated GET/POST parameters so OpenAPI advertises offset and callers get consistent validationGEThandler now accepts the query argument and thePOSTmodel persists it.SearchHandlerseedsQueryInfowith the caller-specified offsets and only returns “previous” links when the offset is greater than 0.