Skip to content

Display stack fetch request errors #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adammw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Display stack fetch request errors #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/sfn/command/diff.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ def execute!

begin
stack = provider.stack(name)
rescue Miasma::Error::ApiError::RequestError
rescue Miasma::Error::ApiError::RequestError => error
ui.error error.message unless error.response.code == 404
stack = nil
end

Expand Down
3 changes: 2 additions & 1 deletion lib/sfn/command/plan.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ def execute!
stack_info = "#{ui.color("Name:", :bold)} #{name}"
begin
stack = provider.stacks.get(name)
rescue Miasma::Error::ApiError::RequestError
rescue Miasma::Error::ApiError::RequestError => error
ui.error error.message unless error.response.code == 404
stack = provider.stacks.build(name: name)
end

Expand Down
3 changes: 2 additions & 1 deletion lib/sfn/command/realize.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ def execute!
stack_info = "#{ui.color("Name:", :bold)} #{name}"
begin
stack = provider.stacks.get(name)
rescue Miasma::Error::ApiError::RequestError
rescue Miasma::Error::ApiError::RequestError => error
ui.error error.message unless error.response.code == 404
raise Error::StackNotFound,
"Failed to locate stack: #{name}"
end
Expand Down
3 changes: 2 additions & 1 deletion lib/sfn/command/update.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ def execute!
stack_info = "#{ui.color("Name:", :bold)} #{name}"
begin
stack = provider.stacks.get(name)
rescue Miasma::Error::ApiError::RequestError
rescue Miasma::Error::ApiError::RequestError => error
ui.error error.message unless error.response.code == 404
stack = nil
end

Expand Down