test: update tests to reflect new libxml2 HTML5 parsing behaviors #3308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-libxml2-html5
branch
from
9cfe51f to
5a4a9c3
Compare
flavorjones
force-pushed
the
flavorjones-libxml2-html5
branch
from
d411303 to
bee1e6e
Compare
and fix some libxml2 HTML5-related changes, specifically around errors that are no longer generated.
- starting to deprecate HTML element description data - working around changed error generation - updated CRLF test
flavorjones
force-pushed
the
flavorjones-libxml2-html5
branch
from
bee1e6e to
f124ef9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
@nwellnhof has done some work in libxml2 to move towards HTML5 parsing behaviors. This branch is intended to update Nokogiri's expectations (primarily tests) as a feedback loop for both projects.
See https://gitlab.gnome.org/GNOME/libxml2/-/issues/758#note_2217350
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
Not so far.