Skip to content

Fixes for recent JRuby updates#3477

Merged
flavorjones merged 2 commits intosparklemotion:mainfrom
headius:jruby_fixes
Mar 23, 2025
Merged

Fixes for recent JRuby updates#3477
flavorjones merged 2 commits intosparklemotion:mainfrom
headius:jruby_fixes

Conversation

@headius
Copy link
Copy Markdown
Contributor

@headius headius commented Mar 18, 2025

This PR will contain fixes for recent JRuby updates, including:

  • jar-dependencies unpinning
  • running jruby-head builds on appropriate Java setup
  • anything else I find that needs updating

jar-dependencies finally stablized and should work properly with
whatever the latest release is.
@headius headius marked this pull request as draft March 18, 2025 17:26
@headius
Copy link
Copy Markdown
Contributor Author

headius commented Mar 18, 2025

Switching fully to Java 21 using https://github.com/actions/setup-java appears to have done the trick.

The problem here was as I suspected: Even if JRuby can find its Java with our JAVA_HOME tweaking (in setup-ruby), the system path will still point at the default Java on GHA (currently 17). By using setup-java we switch both JAVA_HOME and PATH to 21.

Most users running tests for a Ruby library against jruby-head probably won't need the command-line java or javac updated, so we'll wait and see if other projects run into this same problem.

@headius
Copy link
Copy Markdown
Contributor Author

headius commented Mar 18, 2025

Supersedes changes in #3468.

@headius headius marked this pull request as ready for review March 18, 2025 17:41
@headius
Copy link
Copy Markdown
Contributor Author

headius commented Mar 18, 2025

Doing a little cleanup of deprecations as well. Let me know if you want to merge as-is or can wait for a few small tweaks.

@headius
Copy link
Copy Markdown
Contributor Author

headius commented Mar 18, 2025

Actually this can be merged any time. There's enough small deprecations and IntelliJ code suggestions I'll put them in a separate PR.

@headius
Copy link
Copy Markdown
Contributor Author

headius commented Mar 18, 2025

Other PR for cleanup and improvements: #3478

@flavorjones
Copy link
Copy Markdown
Member

Thank you! Looks good.

@flavorjones flavorjones merged commit de3253f into sparklemotion:main Mar 23, 2025
322 of 325 checks passed
@headius headius deleted the jruby_fixes branch March 23, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants