fix: expanded sql leak #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, thank you. I didn't realize you had to free the string, but I guess it makes sense. 🤦🏻♀️ |
from https://www.sqlite.org/c3ref/expanded_sql.html > The strings returned by sqlite3_sql(P) and sqlite3_normalized_sql(P) > are managed by SQLite and are automatically freed when the prepared > statement is finalized. The string returned by > sqlite3_expanded_sql(P), on the other hand, is obtained from > sqlite3_malloc() and must be freed by the application by passing it > to sqlite3_free().
flavorjones
force-pushed
the
flavorjones-fix-expanded-sql-leak
branch
from
88235da to
979e8b2
Compare
tenderlove
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tenderlove
This actually was caught by the test suite in https://github.com/sparklemotion/sqlite3-ruby/actions/runs/7745352446/job/21121203412#step:6:82 but I missed it because we've been having some flaky failures of the valgrind/memcheck suite (see #489).