Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: update vendored sqlite to 3.49.1 #605

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Jan 14, 2025

This skips 3.48.0 and 3.49.0 because the autoconf package is not building properly across all platforms, as noted in comments below.

Note that this PR also updates tests to not expect to be able to load extensions when running on Windows systems using the packaged library. The autoconf amalgamation is not picking up dlopen during configuration on Windows systems and I have been unable to figure out why.

@flavorjones flavorjones force-pushed the flavorjones-dep-sqlite-3.48.0 branch from ce13be6 to be4690c Compare January 15, 2025 16:00
@flavorjones
Copy link
Member Author

This is failing in CI because the pkgconf file being generated by 3.48.0 is not correct. I opened a thread upstream to discuss:

https://sqlite.org/forum/forumpost/35c2397b15

@flavorjones flavorjones force-pushed the flavorjones-dep-sqlite-3.48.0 branch from be4690c to ebed3cb Compare February 6, 2025 15:14
@flavorjones flavorjones changed the title dep: update vendored sqlite to 3.48.0 dep: update vendored sqlite to ~3.48.0~ 3.49.0 Feb 6, 2025
@flavorjones flavorjones changed the title dep: update vendored sqlite to ~3.48.0~ 3.49.0 dep: update vendored sqlite to 3.49.0 Feb 6, 2025
@flavorjones
Copy link
Member Author

Jumping to 3.49.0.

@flavorjones
Copy link
Member Author

The build is breaking on windows now, sigh.

I'm going to try to use the single-file amalgamation because this autoconf change in the upstream is pretty obviously not being used wide in the autoconf amalgamation file (it's been broken in different ways for two major releases now). Will take me a few days to circle back.

@flavorjones flavorjones changed the title dep: update vendored sqlite to 3.49.0 dep: update vendored sqlite to 3.49.1 Feb 18, 2025
@flavorjones flavorjones force-pushed the flavorjones-dep-sqlite-3.48.0 branch 5 times, most recently from 2f5063e to 7cf92b6 Compare February 19, 2025 18:48
@flavorjones flavorjones force-pushed the flavorjones-dep-sqlite-3.48.0 branch 8 times, most recently from 434b67d to 479228a Compare February 20, 2025 15:48
On some platforms where dlopen can't be found at build time,
HAVE_SQLITE3_LOAD_EXTENSION is false by
HAVE_SQLITE3_ENABLE_LOAD_EXTENSION could still be true.

Only define `enable_load_extension` if both are true.
@flavorjones flavorjones force-pushed the flavorjones-dep-sqlite-3.48.0 branch from 479228a to a9733db Compare February 20, 2025 16:06
@flavorjones
Copy link
Member Author

Note that this PR also updates tests to not expect to be able to load extensions when running on Windows systems using the packaged library. The autoconf amalgamation is not picking up dlopen during configuration on Windows systems, and I have been unable to figure out why.

Upstream conversation happened at https://sqlite.org/forum/forumpost/dc98a0daa496cf929fe95c5fb62a2305cca3c7e8c20d20903bcb813b9082e390. But I've timed out on trying to figure out how to fix this. If there are windows users out there who need/want/use this feature, I would love your help fixing/reporting it.

@flavorjones flavorjones merged commit f4e5405 into main Feb 20, 2025
136 checks passed
@flavorjones flavorjones deleted the flavorjones-dep-sqlite-3.48.0 branch February 20, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant