Add support for Keycard

[bitgamma]

Add support for the Keycard hardware wallet. Integrates into the existing card-based wallet architecture.

[craigraw]

Thanks for this. As initial feedback, I am not particularly keen on adding a dependency for a single device, and definitely not keen on adding jitpack as a package repository. Where can the source for this dependency be found?

[bitgamma]

Thanks for this. As initial feedback, I am not particularly keen on adding a dependency for a single device, and definitely not keen on adding jitpack as a package repository. Where can the source for this dependency be found?

The source is at https://github.com/keycard-tech/status-keycard-java (only the lib subproject is being used).

The source could be either copied over or the jar could be hosted in another maven repo.

[craigraw]

Would it be possible to add the minimal source required to this PR in the com.sparrowwallet.sparrow.io.keycard package? i.e. no Ethereum or anything else unncessary. This would better match the satochip and tapsigner integrations.

[bitgamma]

ok, will do

[bitgamma]

Would it be possible to add the minimal source required to this PR in the com.sparrowwallet.sparrow.io.keycard package? i.e. no Ethereum or anything else unncessary. This would better match the satochip and tapsigner integrations.

dependency removed and embedded a reduced version of the Keycard SDK.

[craigraw]

Thanks. This has revealed another problem though:

All use of Bouncy Castle must be done through the drongo submodule - it cannot be added directly as a dependency in Sparrow. Existing code should be reused where possible - see for example ECKey or AESKeyCrypter in the com.sparrowwallet.drongo.crypto package. You may need to write another KeyCrypter subclass however.

[bitgamma]

Thanks. This has revealed another problem though:

All use of Bouncy Castle must be done through the drongo submodule - it cannot be added directly as a dependency in Sparrow. Existing code should be reused where possible - see for example ECKey or AESKeyCrypter in the com.sparrowwallet.drongo.crypto package. You may need to write another KeyCrypter subclass however.

ok direct dependency on BouncyCastle has been removed as well.