-
-
Notifications
You must be signed in to change notification settings - Fork 22
Add 1.21.8 support #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Baktus79
wants to merge
3
commits into
spartacus04:master
Choose a base branch
from
Baktus79:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add 1.21.8 support #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Updated dependencies.
IllegalArgumentException: Invalid slot index 9 for Crafter.
|
Latest commit fixes the error; |
- Prevented overwriting entire inv.contents which broke Crafter. - Added snapshot/restore of disabled slots (BooleanArray). - Only update slots if items actually change. - Keeps Crafter blocks functional after inventory updates.
|
I found that when JEXT is active, disabled slots in the Crafter block are not remembered.
This happens because updateInventory overwrote the entire inv.contents array, which resets the Crafter’s internal disabled slot state. This PR fixes the issue by:
With this change, disabled slots in the Crafter persist correctly when reopening the GUI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Updated dependencies.