feat: allow modifying disc names #733
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(again would like some guidance on the config migration setup for this new property)
My server uses InteractionVisualizer, which is a neat plugin that has one feature showing the currently playing disc as a hologram above a jukebox. It uses the vanilla disc data for the name hovering the jukebox if no custom display name is present. This PR introduces a config variable that lets users set the item name for custom discs with the author and title.
Before: (
disc-modify-item-nameoff, just like before)After: (
disc-modify-item-nameon)