Add BackedEnum Support to Activity::log() #1384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onairmarc What do you think of also adding |
That should probably be a separate PR since it deals with other functionality separate from the log message. |
|
@freekmurze Can this PR please get reviewed? Thanks! 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
BackedEnumsupport to Activity::log(). I find this useful because I use this package in my billing system, where I log why a tenant's status has changed during automated processes. Most of these messages are identical strings, so I thought it would make sense to add support forBackedEnums.If there are any changes or improvements you would like me to make, please let me know. 🤓