Fix : type handling in CleanActivitylogCommand for --days option#1421
Closed
Ayoub-Mabrouk wants to merge 1 commit intospatie:mainfrom
Closed
Fix : type handling in CleanActivitylogCommand for --days option#1421Ayoub-Mabrouk wants to merge 1 commit intospatie:mainfrom
Ayoub-Mabrouk wants to merge 1 commit intospatie:mainfrom
Conversation
Previously, the --days option passed to the activitylog:clean command or the configuration value 'delete_records_older_than_days' could be null or a string. This caused potential type issues when used with Carbon's subDays() method, which expects an integer. This commit explicitly casts the value of to (int), ensuring consistent behavior and preventing runtime errors when calculating the cutoff date for old activity log records. No changes to functionality; purely a type safety improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the --days option passed to the activitylog:clean command or the configuration value 'delete_records_older_than_days' could be null or a string. This caused potential type issues when used with Carbon's subDays() method, which expects an integer.
This commit explicitly casts the value of to (int), ensuring consistent behavior and preventing runtime errors when calculating the cutoff date for old activity log records.
No changes to functionality; purely a type safety improvement.