Skip to content

refactor: improve CleanActivitylogCommand return values and docs #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nick322 wants to merge 1 commit into from
+5 −1
Closed

refactor: improve CleanActivitylogCommand return values and docs #1435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/CleanActivitylogCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ class CleanActivitylogCommand extends Command

public function handle()
{
// If the environment is set to production and the --force option is not provided,
// the cleanup operation will not proceed.
if (! $this->confirmToProceed()) {
return 1;
return Command::FAILURE;
}

$this->comment('Cleaning activity log...');
Expand All @@ -44,5 +46,7 @@ public function handle()
$this->info("Deleted {$amountDeleted} record(s) from the activity log.");

$this->comment('All done!');

return Command::SUCCESS;
}
}