Fix issue where activity is null#1439
Merged
freekmurze merged 4 commits intospatie:mainfrom Jan 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when using the facade it always returns the same
PendingActivityLogobject because facade instances are cached by default. This cuases the following issues:$activityproperty is set tonullafter calling thelogmethod.This causes an issue when starting the chain using the
event()orcausedByAnonymous()methods as they expect the property to be set$log_nameproperty is not set on the activity for consecutive callsWhile disabling the caching of the facade already fixes both of these issues, I also included df95425 to ensure the activity is always accessed the same way.
An alternative fix would be to always return a new instance of
ActivityLoggerfrom thePendingActivityLogclass.Let me know if you prefer the alternative fix instead!