fix subject() throwing exception for non-SoftDeletes models#1442
Merged
freekmurze merged 1 commit intomainfrom Jan 31, 2026
Merged
fix subject() throwing exception for non-SoftDeletes models#1442freekmurze merged 1 commit intomainfrom
freekmurze merged 1 commit intomainfrom
Conversation
When `subject_returns_soft_deleted_models` config is true, the subject() method was calling withTrashed() which throws an exception for models that don't use the SoftDeletes trait. Changed to use withoutGlobalScope(SoftDeletingScope::class) which safely removes the soft delete scope only if it exists. Fixes #456 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subject()throws an exception whensubject_returns_soft_deleted_modelsconfig is true but the subject model doesn't useSoftDeletestraitwithTrashed()towithoutGlobalScope(SoftDeletingScope::class)which safely removes the soft delete scope only if it existsFixes #456
🤖 Generated with Claude Code