Fix activitylog cleanup to require integer days input#1448
Open
sandeep728 wants to merge 1 commit intospatie:mainfrom
Open
Fix activitylog cleanup to require integer days input#1448sandeep728 wants to merge 1 commit intospatie:mainfrom
sandeep728 wants to merge 1 commit intospatie:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents accidental full cleanup in activitylog:clean when an invalid days value is provided.
Problem
CleanActivitylogCommand previously used the days value directly in
Carbon::now()->subDays($maxAgeInDays). When days is invalid (for example false), Carbon effectively treats it like 0 days in this flow, so subDays(...) returns the current date/time. That makes the cutoff become “now”, and the cleanup query can match almost all existing records (created_at < now), causing unintended mass deletion.While callers of the command should ideally validate inputs before invoking the command, this command performs a destructive operation. For safety, I think we should also enforce validation at the command boundary.
Fix
Added strict integer validation before calculating the cutoff date: