Add BackedEnum support for log name#1461
Open
alexanderkroneis wants to merge 1 commit into
Open
Conversation
f88ecfa to
ba2a972
Compare
ba2a972 to
1bd9198
Compare
1bd9198 to
fcccac6
Compare
Author
|
@claude Can you review what I submitted? Think about edge cases, breaking changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BackedEnum support for log names
You can now use a string- or int-backed enum as a log name. The enum's
valueis stored in the database.
By default log_name reads back as a string. To hydrate it back into an enum, set the class in the config:
Note
default_log_enumis global, so only one enum applies. Log names that aren't one of its values (e.g. default) come back as plain strings.