Closed
Conversation
Collaborator
|
Hey @moisish, thanks for the PR! Since TenantFinder is fully swappable via config, you can add a caching layer in your own implementation without needing changes to the package itself — keeping things flexible per project. Also, the test suite is currently failing, so we can't merge this as-is. Thanks again for the contribution, we appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tenant resolution via
TenantFinderhits the database on every request. This PR adds an opt-in caching decorator that wraps anyTenantFinderimplementation and caches the resolved tenant.What's included
CachingTenantFinder— a decorator that wraps the configuredTenantFinder, caches the result, and delegates to the inner finder on cache miss. Supports configurable TTL, cache store, and forever-cache (ttl: 0). Null results are intentionally not cached.CachesTenantFinderResults— interface exposingforget(Request)andforgetByKey(string)for cache invalidation, allowing other packages to type-hint without dependingon the concrete class.