Switch passing mjml via argument to via stdin#31
Merged
riasvdv merged 1 commit intospatie:mainfrom Mar 17, 2025
Merged
Conversation
Alternate fix to bug spatie#25
Contributor
|
Do we still need the base64 encoding/decoding when using stdin or can we skip it in that case as well? |
Contributor
Author
|
In theory the base64 could be skipped, however I wasn't confident that some odd byte-sequence such as an EOF, or something UTF-8 would break anything on any specific platform. I am only able to test on a Linux system at the moment. The base64 encoding seemed easy enough to leave as a defensive measure. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate fix to bug #25