Fix PHP 8.3 and Laravel 10 compatibility#361
Merged
Merged
Conversation
Change testbench version from wildcard (8.*) to caret (^8.22) to prevent installation of incompatible versions during prefer-lowest installations.
- Lower PHP requirement from ^8.4 to ^8.3 to align with run-tests.yml - Add support for Pest v2 alongside v3 (^2.0||^3.0) for Laravel 10 compatibility - Adjust pest plugin constraints to support both v2 and v3 - pestphp/pest-plugin-arch ^2.5 required for arch() method support
Member
|
Thanks! |
fzengin19
pushed a commit
to fzengin19/laravel-subscription-guard
that referenced
this pull request
Mar 6, 2026
Fix PHP 8.3 and Laravel 10 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes compatibility issues between composer.json requirements and the GitHub Actions workflow, enabling support for PHP 8.3+ and Laravel 10+.
Problem
The current template has several compatibility issues:
Solution
composer.json changes:
^8.4to^8.3to match the workflow matrix^2.0||^3.0) for Laravel 10 compatibilityWorkflow changes:
8.*) to caret (^8.22) to ensure compatible versionsTesting
I've created a test package that demonstrates these changes work correctly: https://github.com/christopheraseidl/test-skeleton-patch
This test package shows: